Checkbox labels should not be hidden in inline forms #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…should not happen for checkbox elements, which need their label to function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is the same issue fixed in yiisoft/yii2-bootstrap4#243 for bootstrap 4.
--
Inline forms by default hide all labels with the sr-only class. This should not happen for checkbox elements, which need their label to function. Without a visible label, the checkbox will not function in bootstrap. And even if it did, a checkbox without a label is not really usable.
The method for class removal is based on similar exceptions made in the listBox() and dropDownList() methods in the same class.