Fix package.json exports #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yiliansource it would be great if you could merge this, since it's preventing me from using your library. Thanks! |
|
I was not aware that this would cause issues, thanks! Do you know if this change would cause any compatibility issues as a patch? |
I can't imagine this change would break anything |
|
I also think that this is safe to merge. |
|
@yiliansource thank you! It works now. |
|
Wooww! Thanks dude |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into some problems using this package with svelte kit/vite when building for production. The root of my problem seems to be that the ECMAScript module loader does not support directories/folders as modules. See https://nodejs.org/api/packages.html.
Also, this might be related to #89.