-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make drag & drop to work as input file in step 3 #11
base: master
Are you sure you want to change the base?
Conversation
- Hold the selected files blobs in the elements of the inputs - On 'let check' clicked get the blobs and restore the empty state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Haim,
Thanks for uploading the patch. Could you kindly describe what problem you encountered? The drag & drop can move to step 4 (and comparison) on my side.
Maybe you can provide info like the steps to reproduce the issue (and browser / platform version).
Thanks in advance.
Hi, By the way, if you need any help with bugs or features for this wonderful project I will love to give a hand for it. |
Ohoh! This is working as intended. But you brought up a good point of making the UX consistency. We actually had a discussion on this before. The original design was moving to step 4 immediately once any file is selected or dropped. This can save a click. But another partner suggested to add a button for file selection. The reason is that when user clicks the , a dialog will pop up, which is like a new context. Then after the user selects a file, the dialog will disappear and user will feel like a context switch back to the main page. In this time, if we move to step 4 immediately, the user may feel discontinued because they were still in the step 3 context. So, a "next step" click is required here to let user knows we are moving forward. So the un-consistency is intended so that user is aware of the step transition. But I will keep in mind about your solution -- because I personally prefer removing the click. :-) Anyway, thank you for uploading this PR. Feel free to submit PR if you see anything can be improved. |
No description provided.