Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update local field but not trigger change event. #10

Merged
merged 1 commit into from
Apr 17, 2021

Conversation

ulion
Copy link
Contributor

@ulion ulion commented Apr 9, 2021

when update the state get from the local state map, the value in local state map already updated, so it always deep compare failure then no change event is emitted.
This PR fix this issue.

@dmonad
Copy link
Member

dmonad commented Apr 17, 2021

Makes sense. Thank you!

@dmonad dmonad merged commit 8a70262 into yjs:master Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants