Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sync.js #22

Merged
merged 1 commit into from
Oct 1, 2022
Merged

Update sync.js #22

merged 1 commit into from
Oct 1, 2022

Conversation

aryzing
Copy link
Contributor

@aryzing aryzing commented Aug 11, 2022

Updated the comment. As it was written, it felt as if this library performed the actual sending of the message contained in encoder. However, this library is network agnostic.

Rather, it seems, it's up to the server using this lib whether it wants to send the message or not, and should not send it if it detects the message is empty (as seen here).

Updated the comment. As it was written, it felt as if this library performed the actual sending of the message contained in `encoder`. However, this library is network agnostic. 

Rather, it seems, it's up to the server using this lib whether it wants to send the message or not, and should not send it if it detects the message is empty (as seen [here](https://github.com/yjs/y-websocket/blob/625a9d52ba8bcff90a941d51ae151869e220f368/bin/utils.js#L171)).
@dmonad
Copy link
Member

dmonad commented Oct 1, 2022

Thank you, that makes sense!

@dmonad dmonad merged commit 441ce49 into yjs:master Oct 1, 2022
@aryzing aryzing deleted the patch-1 branch October 2, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants