Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

支持设置深色主题,并跟随系统设置改变 #38

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

elxy
Copy link
Contributor

@elxy elxy commented Jan 21, 2024

用了几天,没遇到啥问题。不过ThemeChangeDialogFragment.java里面的public Dialog onCreateDialog()函数,也和主题设置有关,不知道是否需要修改。

@ykrank
Copy link
Owner

ykrank commented Feb 4, 2024

用了几天,没遇到啥问题。不过ThemeChangeDialogFragment.java里面的public Dialog onCreateDialog()函数,也和主题设置有关,不知道是否需要修改。

这个dialog是快速切换主题的dialog,如果不改,那快速切主题就只对白天模式生效?

@elxy
Copy link
Contributor Author

elxy commented Feb 5, 2024

用了几天,没遇到啥问题。不过ThemeChangeDialogFragment.java里面的public Dialog onCreateDialog()函数,也和主题设置有关,不知道是否需要修改。

这个dialog是快速切换主题的dialog,如果不改,那快速切主题就只对白天模式生效?

快速切换主题的dialog是指设置里的主题选择么?试了下,对白天模式和深色模式都会生效——选择主题后会触发主题切换的效果。这样的话,感觉就没啥bug了。Rank有空可以试试~

@ykrank ykrank merged commit 0c0b0fd into ykrank:master Mar 22, 2024
@elxy elxy deleted the feat/dark_theme branch March 22, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants