Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureAD] Changed AAD resource name to AzureAD #9

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Conversation

avarga77
Copy link
Contributor

Pull Request

Pull Request (PR) description

Added

Changed

  • Changed AAD resource name to AzureAD

Deprecated

Security

Fixed

Removed

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@ykuijs
Copy link
Owner

ykuijs commented Nov 27, 2023

Agree with this change, but just wondering: Shouldn't we use Entra ID while we are at it? Of would that only cause more confusion, since the resources are still called AAD*?

@avarga77
Copy link
Contributor Author

Agree that the long term naming should be EntraID. But I'd wait with it until M365DSC itself will rename the resources, just as you said, to avoid confusion. I see that some tests failed, so I have to look a the test modules again. :)

@ykuijs ykuijs merged commit bfec6d8 into ykuijs:main Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants