feat(term): set timeout for the github client

ymgyt · Aug 31, 2024 · 96e4762 · 96e4762
1 parent 35981ef
commit 96e4762
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/crates/synd_term/Cargo.toml b/crates/synd_term/Cargo.toml
@@ -38,7 +38,7 @@ humantime            = { workspace = true }
 itertools            = { workspace = true }
 nom                  = { version = "7.1.3", default-features = false, features = ["std"] }
 nucleo               = "0.5.0"
-octocrab             = { workspace = true }
+octocrab             = { workspace = true, features = ["timeout", "tracing"] }
 open                 = "5.3.0"
 ratatui              = { version = "0.28.1" }
 reqwest              = { workspace = true }

diff --git a/crates/synd_term/src/client/github/mod.rs b/crates/synd_term/src/client/github/mod.rs
@@ -46,7 +46,10 @@ impl GithubClient {
     pub fn new(pat: impl Into<String>) -> Self {
         // TODO: configure timeout
         let octo = Octocrab::builder()
-            .personal_token(pat.into())
+            .personal_token(pat)
+            .set_connect_timeout(timeout)
+            .set_read_timeout(timeout)
+            .set_write_timeout(timeout)
             .build()
             .unwrap();
         Self::with(octo)

diff --git a/crates/synd_term/src/config/mod.rs b/crates/synd_term/src/config/mod.rs
@@ -80,9 +80,12 @@ pub mod cache {
 }
 
 pub(crate) mod github {
+    use std::time::Duration;
+
     /// GitHub pagination rest api is 1 origin
     pub(crate) const INITIAL_PAGE_NUM: u8 = 1;
     pub(crate) const NOTIFICATION_PER_PAGE: u8 = 40;
+    pub(crate) const CLIENT_TIMEOUT: Duration = Duration::from_secs(30);
 }
 
 pub(crate) mod theme {