Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(term): add github filter conditions #85

Merged
merged 3 commits into from
Jul 5, 2024
Merged

feat(term): add github filter conditions #85

merged 3 commits into from
Jul 5, 2024

Conversation

ymgyt
Copy link
Owner

@ymgyt ymgyt commented Jul 5, 2024

  • chore: use rust-overlay
  • feat(term): add filter conditions to github notification

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 53.99188% with 340 lines in your changes missing coverage. Please review.

Project coverage is 82.44%. Comparing base (cbc77e0) to head (23364c6).

Files Patch % Lines
...src/ui/components/gh_notifications/filter_popup.rs 8.73% 187 Missing and 1 partial ⚠️
...ynd_term/src/ui/components/gh_notifications/mod.rs 29.47% 65 Missing and 2 partials ⚠️
crates/synd_term/src/ui/components/filter/mod.rs 69.30% 18 Missing and 13 partials ⚠️
crates/synd_term/src/types/github.rs 30.43% 8 Missing and 8 partials ⚠️
crates/synd_term/src/client/github/mod.rs 20.00% 8 Missing ⚠️
...d_term/src/ui/components/collections/filterable.rs 0.00% 7 Missing ⚠️
crates/synd_term/src/application/mod.rs 50.00% 5 Missing and 1 partial ⚠️
...tes/synd_term/src/ui/components/filter/composed.rs 75.00% 6 Missing ⚠️
...tes/synd_term/src/ui/components/filter/category.rs 81.81% 4 Missing ⚠️
...ates/synd_term/src/ui/components/filter/matcher.rs 90.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   80.48%   82.44%   +1.96%     
==========================================
  Files         113      117       +4     
  Lines        8712     9275     +563     
  Branches     8712     9275     +563     
==========================================
+ Hits         7012     7647     +635     
+ Misses       1459     1346     -113     
- Partials      241      282      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ymgyt ymgyt merged commit a1135c7 into main Jul 5, 2024
4 checks passed
@ymgyt ymgyt deleted the gh-filter-2 branch July 5, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant