Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish job: Ignore unfilled output dir #133

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Submit publish job does not set OutputDirectory if template cannot be filled.

Additional review information

The reason why template cannot be filled may wary, one usecase might be that studio uses {representation} in directory template, which is not available when submitting job.

Testing notes:

  1. Use {representation} in directory publish template.
  2. Submit job to deadline.
  3. Job should be submitted without output directory, and the publishing does not crash.

# Conflicts:
#	client/ayon_deadline/plugins/publish/global/submit_publish_job.py
@iLLiCiTiT iLLiCiTiT added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Feb 19, 2025
@iLLiCiTiT iLLiCiTiT self-assigned this Feb 19, 2025
@iLLiCiTiT iLLiCiTiT requested review from BigRoy, kalisp and 64qam February 19, 2025 09:42
@iLLiCiTiT iLLiCiTiT added type: enhancement Improvement of existing functionality or minor addition and removed type: enhancement Improvement of existing functionality or minor addition labels Feb 19, 2025
@iLLiCiTiT iLLiCiTiT merged commit c93af71 into develop Feb 19, 2025
3 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/ignore-missing-output-dir branch February 19, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants