Sequence and shot folder grouping

[kalisp]

Changelog Description

Synchronized sequences and shots were stored directly in root of the AYON project previously. This PR adds configurable option to set main assets, sequences and shots subdirectories.

Additional info

Previously seq0 would be directly next to environment, without wrapping sequences folder

There might be discussion needed for current implementation of shots without sequences in SG (if it makes actually sense in production). I implemented it according to requirements, but it might be just misunderstanding.

! For running projects ayon+settings://shotgrid/compatibility_settings/folder_locations should be purged to keep original implementation. (Or maybe changed defaults OR changed initialization of this addon???)

Implemented 2 workflows:

This will reparent all SG Assets under assets category, all Sequences and their Shot children under sequences.
Resulting in:

##############################
Second use case

Will separate SG Assets into AYON assets, SG Sequences into sequences, Shots into /shots/new_shots
Resulting in:

Testing notes:

1. check ayon+settings://shotgrid/compatibility_settings/folder_parenting if it matches your requirements
2. synchronize from Shotgrid to AYON
3. shots folder is for shots without sequences (which is possible in SG)

[ynbot]

Task linked: AY-6666 Shotgrid: sequence and shot folder grouping

[fabiaserra]

I personally don't think this feature makes much sense. I imagine this comes after this request #126 ? As I commented there, I think it makes sense to group all asset entities under a folder called assets and all shot based entities (this includes episodes, sequences and shots) under one called shots (or whatever) but splitting each entity into its own category beats the purpose in my opinion. Are shots parented to sequences going under the root sequences folder?

[kalisp]

Are shots parented to sequences going under the root sequences folder they would now (but they shouldn't according to requirements, sequences should contain only sequences)

I am open to ideas how to configure it to be more universal as this is sponsored issue, but I agree it might not apply to all use cases, same as yours doesn't.

[fabiaserra]

Are shots parented to sequences going under the root sequences folder they would now (but they shouldn't according to requirements, sequences should contain only sequences)

So where are shots parented to sequences go? Or a sequence child of an episode and that episode having sequences and then shots? Could you put some examples of the different cases?

[BigRoy]

I'm so clueless about these conversations - doesn't shotgrid just have hierarchies itself? And shouldn't we just adhere to that hierarchy 1:1? Or what makes this so complex?

[fabiaserra]

I'm so clueless about these conversations - doesn't shotgrid just have hierarchies itself? And shouldn't we just adhere to that hierarchy 1:1? Or what makes this so complex?

Yeah I'm a bit confused too tbh, I thought the request was to have it just on disk (which wouldn't require to create the entities in the server and it's just a template thing) and just as a means to encapsulate ALL of the shots (with its respective hierarchy) within. On the other hand, if they want those categories to show up on the UIs that's something we can do in the frontend agnostic of shotgrid as the folder types exist, it's basically just an extension to the existing icons?

Fixed

[MilaKudr]

Both methods work fine for me. For some reason there is a one minute delay (waiting) between pressing the Sync button (SG -> AYON) since the Processor service begin to do something, lets see if this can be improved.

[jakubjezek001]

2024-11-29 12:03:58.215 INFO: Event has been processed... setting to finished!
2024-11-29 12:03:58.971 ERROR: Unable to create Task <9f491990ae4111efb21b85431f85a5f6> in Shotgrid!
Traceback (most recent call last):
  File "C:\CODE\__YNPUT\ayon-shotgrid\services\shotgrid_common\ayon_shotgrid_hub\update_from_ayon.py", line 83, in create_sg_entity_from_ayon_event
    sg_entity = _create_sg_entity(
                ^^^^^^^^^^^^^^^^^^
  File "C:\CODE\__YNPUT\ayon-shotgrid\services\shotgrid_common\ayon_shotgrid_hub\update_from_ayon.py", line 340, in _create_sg_entity
    raise ValueError(
ValueError: Parent does not exist in Shotgrid!None <None>

This is happening only with Transmitter once a AY project is set to shotgrid_push activated for auto syncing based on AY changes.

---

Edit:
So the another examination of the issue discovered following issue at this testing:

• Shots in Relocate Root workflow is synchronized but parent (in AY under a Sequence) is not correctly set.
• The above issue was caused by wrong setting Folder type on shot (Shotgrid is not supporting Folder type)

[jakubjezek001]

We will be sorting the parenting issue in consequent PR @kalisp please. But let's not do new release until the parenting is solved @m-u-r-p-h-y @tatiana-ynput .

[kalisp]

I fixed parenting, it wasn't caused by changes in this PR though.