Remove and search notes

[AyushP90]

Short description of what this resolves:

Delete notes and search for them using a substring

Changes proposed in this pull request:

• Can remove notes now
• Searching is done using substring matching
• Temporary fix to 42

Fixes: #42

[codecov-io]

Codecov Report

Merging #59 into master will decrease coverage by 0.71%.
The diff coverage is 6.52%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   27.61%   26.89%   -0.72%     
==========================================
  Files          18       18              
  Lines        1159     1201      +42     
==========================================
+ Hits          320      323       +3     
- Misses        839      878      +39

Impacted Files	Coverage Δ
yoda.py	38.2% <ø> (ø)	⬆️
setup.py	100% <ø> (ø)	⬆️
util.py	32.14% <25%> (-0.55%)	⬇️
modules/diary.py	16.58% <4.76%> (-2.58%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e21752...cc4b021. Read the comment docs.

[manparvesh]

Please make the commented changes and also remove the 2 .swp files

[manparvesh]

please remove the above .swp files

[manparvesh]

please remove the changes from this file

[manparvesh]

please reformat the files you've changed using autopep8 after you're finished working on them

[manparvesh]

Sorry, this is not what I meant by searching the notes. I would like to give the user an option to search in the previous notes. There is no point in searching today's notes, right?

[AyushP90]

Thanks I'll work on it.

…

On 12-Dec-2017 5:23 PM, "Man Parvesh Singh Randhawa" < ***@***.***> wrote: ***@***.**** requested changes on this pull request. Please make the commented changes and also remove the 2 .swp files ------------------------------ In modules/diary.py <#59 (comment)>: > @@ -237,7 +237,63 @@ def complete_task(): chalk.red( please remove the above .swp files ------------------------------ In resources/vocab-words.txt <#59 (comment)>: > @@ -676,3 +676,5 @@ parlous - full of danger or uncertainty; precarious pilloried - attack or ridicule publicly; pillory is a wooden shackle expatiate - speak or write at length or in detail man - someone who serves in the armed forces; a member of a military force +work - make uniform please remove the changes from this file ------------------------------ In modules/diary.py <#59 (comment)>: > time = entry['time'] text = entry['text'] - click.echo(time + "| " + text) + click.echo("--" + str(counter) + "---|" + time + "| " + text) please reformat the files you've changed using autopep8 after you're finished working on them ------------------------------ In modules/diary.py <#59 (comment)>: > + if search_string.lower() in text.lower(): + if found==0: + click.echo('Following notes match your search:') + click.echo("--------------") + click.echo(" Time | Note") + click.echo("--------|-----") + click.echo(time + "| " + text) + found=1 + + if found==0: + click.echo('No notes found having the above substring') + + else: + chalk.red( + 'There are no notes for today. Add a new note by entering "yoda diary nn"') + Sorry, this is not what I meant by searching the notes. I would like to give the user an option to search in the previous notes. There is no point in searching today's notes, right? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#59 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVzq18LJJoKghJRxRuZ9YMJClNsnXuFPks5s_mkbgaJpZM4Q-pyi> .