If a feed can't be downloaded, ignore the error and try the rest of t…

…he feeds.
yodax · Jul 18, 2015 · ba56e77 · ba56e77
1 parent dbb3556
commit ba56e77
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 9 deletions.
diff --git a/Subtitle.Downloader.Tests/WhenDownloadingFromAFaultyFeed.cs b/Subtitle.Downloader.Tests/WhenDownloadingFromAFaultyFeed.cs
@@ -1,6 +1,8 @@
 using System.Collections.Generic;
 using FluentAssertions;
+using NSubstitute;
 using NUnit.Framework;
+using Subtitle.Common;
 using Subtitle.Provider.Addic7ed;
 
 namespace Subtitle.Downloader.Tests
@@ -26,5 +28,30 @@ public void TheFaultyItemShouldBeIgnored()
 
             foundLinks.Count.Should().Be(6);
         }
+
+        [Test]
+        public void IfTheDownloadFailsTheExceptionShouldBeEaten()
+        {
+            var foundLinks = new List<FoundLink>();
+
+            var feedLinks = new List<string>
+            {
+                "Exception.xml",
+                "FaultyRss.xml",
+            };
+
+            var download = Substitute.For<IDownload>();
+
+            download.From("FaultyRss.xml")
+                .Returns(new ResourceDownload().From("FaultyRss.xml"));
+            download.From("Exception.xml")
+                .Returns(d => { throw new System.Net.WebException(); });
+
+            var linkFinder = new LinkFinder(foundLinks, download);
+
+            linkFinder.LookForLinksFromFeeds(feedLinks);
+
+            foundLinks.Count.Should().Be(6);
+        }
     }
 }
diff --git a/Subtitle.Provider.Addic7ed/AddictedFeedReader.cs b/Subtitle.Provider.Addic7ed/AddictedFeedReader.cs
@@ -3,7 +3,7 @@
 
 namespace Subtitle.Provider.Addic7ed
 {
-    public class AddictedFeedReader
+    public static class AddictedFeedReader
     {
         public static IEnumerable<string> GetAllLinksFrom(string feedContent)
         {

diff --git a/Subtitle.Provider.Addic7ed/LinkFinder.cs b/Subtitle.Provider.Addic7ed/LinkFinder.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Net;
 using Subtitle.Common;
 
 namespace Subtitle.Provider.Addic7ed
@@ -21,14 +22,20 @@ public void LookForLinksFromFeeds(IEnumerable<string> feedLinks)
             var linksFoundFromFeeds = new List<FoundLink>();
             foreach (var feedLink in feedLinks)
             {
-                linksFoundFromFeeds.AddRange(AddictedFeedReader
-                    .GetAllLinksFrom(_download.From(feedLink))
-                    .Where(l => l.Contains("/serie/"))
-                    .Select(s => new FoundLink
-                    {
-                        Link = s,
-                        FoundOn = DateTime.Now
-                    }));
+                try
+                {
+                    var feedContent = _download.From(feedLink);
+                    linksFoundFromFeeds.AddRange(AddictedFeedReader
+                        .GetAllLinksFrom(feedContent)
+                        .Where(l => l.Contains("/serie/"))
+                        .Select(s => new FoundLink
+                        {
+                            Link = s,
+                            FoundOn = DateTime.Now
+                        }));
+                }
+                catch (WebException){}
+
             }
 
             AddFoundLinksToStore(linksFoundFromFeeds);