Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: update GitHub action versions #1136

Merged
merged 1 commit into from
Dec 16, 2023
Merged

CI: update GitHub action versions #1136

merged 1 commit into from
Dec 16, 2023

Conversation

jxdv
Copy link
Contributor

@jxdv jxdv commented Dec 13, 2023

  • updated checkout action to the newest version
  • codeql version 1 actions were deprecated in january 2023, therefore updated to version 2

@AnonymousWP
Copy link
Contributor

Have you tested this on your forked repo?

@jxdv
Copy link
Contributor Author

jxdv commented Dec 13, 2023

Have you tested this on your forked repo?

Yes, everything works as expected + you can also see all the Code Quality pipelines pass here.

@AnonymousWP AnonymousWP merged commit 22585a5 into yogeshojha:master Dec 16, 2023
3 of 5 checks passed
@AnonymousWP
Copy link
Contributor

https://github.com/yogeshojha/rengine/actions/runs/7233595382

Hmm.

@psyray
Copy link
Contributor

psyray commented Dec 16, 2023

This seems to be good now, no ?

@jxdv jxdv deleted the update-workflows branch December 16, 2023 19:07
@jxdv
Copy link
Contributor Author

jxdv commented Dec 16, 2023

I found an issue regarding this same thing. Following the steps in #1126 might resolve this.

@yogeshojha yogeshojha added this to the release 2.0.3 milestone Dec 18, 2023
@AnonymousWP
Copy link
Contributor

As I don't have the sufficient permissions to follow these steps: @yogeshojha can you please look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnonymousWP AnonymousWP AnonymousWP approved these changes

@psyray psyray psyray approved these changes

@yogeshojha yogeshojha Awaiting requested review from yogeshojha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jxdv @AnonymousWP @psyray @yogeshojha