Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Telegram Push Bug by Encoding # in URLs #1447

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

simonlee-hello
Copy link

Description: This pull request resolves an issue where the # character in messages was causing Telegram API requests to misinterpret everything after # as a URL fragment (hash), leading to incomplete or incorrect message delivery.

In URLs, the # symbol is used to denote the start of a fragment identifier, so when it appears unencoded in the message content, it causes the Telegram API to truncate or mishandle the message.

Changes:

Applied URL encoding to the message content using urllib.parse.quote to escape special characters like #. This ensures that the entire message, including text after #, is correctly transmitted to Telegram.

Code Before:

send_url = f'https://api.telegram.org/bot{telegram_bot_token}/sendMessage?chat_id={telegram_bot_chat_id}&parse_mode=Markdown&text={message}'

Code After:

message = quote(message)
send_url = f'https://api.telegram.org/bot{telegram_bot_token}/sendMessage?chat_id={telegram_bot_chat_id}&parse_mode=Markdown&text={message}'

By URL encoding the message, we ensure that characters like # are safely transmitted, preventing Telegram from misinterpreting them as hash fragments in URLs.

Copy link
Contributor

Woohoo @simonlee-hello! 🎉 You've just dropped some hot new code! 🔥

Hang tight while we review this! You rock! 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant