-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Telegram Push Bug by Encoding # in URLs #1447
Open
simonlee-hello
wants to merge
14
commits into
yogeshojha:master
Choose a base branch
from
simonlee-hello:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Woohoo @simonlee-hello! 🎉 You've just dropped some hot new code! 🔥 Hang tight while we review this! You rock! 🤘 |
Change workers concurrency.
Change workers concurrency.
http_crawl: declutters url lists before httpx.
…aused by the default value 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This pull request resolves an issue where the # character in messages was causing Telegram API requests to misinterpret everything after # as a URL fragment (hash), leading to incomplete or incorrect message delivery.
In URLs, the # symbol is used to denote the start of a fragment identifier, so when it appears unencoded in the message content, it causes the Telegram API to truncate or mishandle the message.
Changes:
Applied URL encoding to the message content using urllib.parse.quote to escape special characters like #. This ensures that the entire message, including text after #, is correctly transmitted to Telegram.
Code Before:
Code After:
By URL encoding the message, we ensure that characters like # are safely transmitted, preventing Telegram from misinterpreting them as hash fragments in URLs.