fix(external_tools): incorrect "update available" strings

[AnonymousWP]

Fixes

• Incorrect update string theHarvester: before, it somehow detected version v5, which doesn't even exist. However, the current version ('v3') isn't detected properly and I'm not sure how to solve it. It doesn't even seem to update the tool, but that could also be a detection issue as I said.

Before:

After:

Changes

• Incorrect version number of reNgine at login page

[psyray]

Why don't use v\d.* as regex for naabu?

Because Naabu doesn't return the v

naabu -version

                  __
  ___  ___  ___ _/ /  __ __
 / _ \/ _ \/ _ \/ _ \/ // /
/_//_/\_,_/\_,_/_.__/\_,_/

		projectdiscovery.io

[INF] Current Version: 2.1.7

Feel free to improve my bad regex 😉

I don't know why but without the space at the beginning the version returned is v34, but with the space it returned 2.1.7
It's weird ...

Without the space before

With the space before

[AnonymousWP]

I pushed some new commits, but I think some of your external_tools.yaml are incorrect: I believe is_github_cloned should only be true if update_command is done by a git pull and the install_command is git clone <repo_url>. Now you've changed that are installed by Go to true as well.

@psyray Can you let me know what you think of it?

[AnonymousWP]

I don't think it has the desired result, lol. A lot still can't recognise the version, and if it can, the version number remains the same after updating. It's very annoying.

[AnonymousWP]

Lot of conflicts due to rebase and now being outdated.

[psyray]

We could close this one, I have reworked this part on PR #995 and it has been merged