-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storytellers #22565
Closed
Closed
Storytellers #22565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yogbot-13
added
Feature
This adds new content to the game
Fix
This fixes an issue. Please link issues in fix PRs
Revert / Deletion
Altoids is probably mad about this
Tweak
This PR contains changes to the game.
labels
Aug 29, 2024
github-actions
bot
added
Admin
This PR affects administrators
Mapping
Will result in a change to a map.
labels
Aug 29, 2024
Hopefully will make boring as hell rounds actually have something going on!!! (idk what storytellers really do) |
What are the effects of adding this feature? |
Hell yea |
Yogbot-13
added a commit
that referenced
this pull request
Sep 29, 2024
just use #22661 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Admin
This PR affects administrators
Feature
This adds new content to the game
Fix
This fixes an issue. Please link issues in fix PRs
Revert / Deletion
Altoids is probably mad about this
Test Merge - Requested
This PR is waiting for a test merge to be scheduled
Test Merge - Scheduled
This PR is waiting to be test merged
Tweak
This PR contains changes to the game.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filled out by Molti, not biome
ported from
Monkestation/Monkestation2.0#461
Monkestation/Monkestation2.0#549
Monkestation/Monkestation2.0#552
Monkestation/Monkestation2.0#622
Monkestation/Monkestation2.0#952
Monkestation/Monkestation2.0#1135
Monkestation/Monkestation2.0#1427
among others (really just sorta stole it directly from their current codebase)
Why is this good for the game?
Dynamic is less dynamic than would be ideal and requires more work to update, maintain, and improve that we have
Storytellers is both more flexible to start, and is a lot easier to understand from a coding perspective, making it far less of a resource drain on our dev team to maintain
Testing
constant work in progress
Wiki Documentation
good luck mord
🆑
rscadd: Adds the storytellers from Monke (and originally horizon)
rscdel: Expunges dynamic from the codebase
/:cl: