Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes old PDAs #22671

Merged
merged 10 commits into from
Oct 13, 2024
Merged

Conversation

JohnFulpWillard
Copy link
Contributor

@JohnFulpWillard JohnFulpWillard commented Oct 3, 2024

Document the changes in your pull request

  • Removes all instances of old PDAs
  • Removes message console's ability to fake messages (it only worked for old PDAs, can re-add if you make them work on new ones instead)
  • Replaces pAI's messenger with their own tablet so they actually get to keep theirs.
  • Makes PDA painter work with new PDAs/Phones instead (done by ynot01)

Why is this good for the game?

old PDAs are nearly completely unused and the few places they are used barely function, faking messages is utterly useless to anyone that isn't a pAI, and said pAI would then just immediately question why they are getting a PDA message when there's no way to obtain one in-game.
This is all just very messy and fucked up so it's better to remove them and start better support for the new PDAs in the future instead.

Testing

Tested pAIs buying and using their new PDA
Tested pAIs using their signaler cause I messed with that
Tested changing people's names as Admin to ensure PDAs were renamed as well
Tested PDA painters on PDAs and phones.

Not really much else to test since basically everything else is removal.

Changelog

🆑 JohnFulpWillard & ynot01
rscdel: Removed old PDAs and the ability to fake messaging with the telecomms messaging monitor console.
tweak: PDA painters now work with new PDAs and phones.
tweak: pAIs now use new PDAs.
/:cl:

@JohnFulpWillard JohnFulpWillard requested a review from a team as a code owner October 3, 2024 01:27
@Yogbot-13 Yogbot-13 added the Revert / Deletion Altoids is probably mad about this label Oct 3, 2024
@ynot01
Copy link
Contributor

ynot01 commented Oct 3, 2024

Removes message console's ability to fake messages (it only worked for old PDAs, can re-add if you make them work on new ones instead)

A new console function is not needed since PDAs can set their username to anything they like, all the syndicates need is access to PDAs

@github-actions github-actions bot added the Mapping Will result in a change to a map. label Oct 3, 2024
@AMyriad
Copy link
Contributor

AMyriad commented Oct 3, 2024

I knew this day would come
alas just renaming them to "antique PDAs" couldn't save them 😔 (thanks for doing this)

Copy link
Contributor

@AMyriad AMyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 rep decluttered hop offices

@ynot01 ynot01 added the Test Merge - Requested This PR is waiting for a test merge to be scheduled label Oct 6, 2024
Yogbot-13 added a commit that referenced this pull request Oct 10, 2024
ynot01
ynot01 previously requested changes Oct 11, 2024
Copy link
Contributor

@ynot01 ynot01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo whatever you did to the PDA painters, I will make them work with new PDAs (biome approved)

@ynot01 ynot01 added Awaiting - Action - Author This PR is awaiting an action from the author and removed Test Merge - Requested This PR is waiting for a test merge to be scheduled labels Oct 11, 2024
@JohnFulpWillard JohnFulpWillard marked this pull request as draft October 12, 2024 01:35
@ynot01 ynot01 removed the Awaiting - Action - Author This PR is awaiting an action from the author label Oct 12, 2024
@JohnFulpWillard JohnFulpWillard marked this pull request as ready for review October 12, 2024 18:22
@ynot01 ynot01 dismissed their stale review October 12, 2024 18:23

implemented pda painters

Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

byee

@ToasterBiome ToasterBiome merged commit a642b2b into yogstation13:master Oct 13, 2024
14 checks passed
@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Will result in a change to a map. Revert / Deletion Altoids is probably mad about this Tweak This PR contains changes to the game.
Projects
Status: Completed Ports
Development

Successfully merging this pull request may close these issues.

5 participants