-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes old PDAs #22671
Removes old PDAs #22671
Conversation
A new console function is not needed since PDAs can set their username to anything they like, all the syndicates need is access to PDAs |
I knew this day would come |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 rep decluttered hop offices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo whatever you did to the PDA painters, I will make them work with new PDAs (biome approved)
updates pda painter to work with new pdas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
byee
Document the changes in your pull request
Why is this good for the game?
old PDAs are nearly completely unused and the few places they are used barely function, faking messages is utterly useless to anyone that isn't a pAI, and said pAI would then just immediately question why they are getting a PDA message when there's no way to obtain one in-game.
This is all just very messy and fucked up so it's better to remove them and start better support for the new PDAs in the future instead.
Testing
Tested pAIs buying and using their new PDA
Tested pAIs using their signaler cause I messed with that
Tested changing people's names as Admin to ensure PDAs were renamed as well
Tested PDA painters on PDAs and phones.
Not really much else to test since basically everything else is removal.
Changelog
🆑 JohnFulpWillard & ynot01
rscdel: Removed old PDAs and the ability to fake messaging with the telecomms messaging monitor console.
tweak: PDA painters now work with new PDAs and phones.
tweak: pAIs now use new PDAs.
/:cl: