Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

healium tweaks p3 #22843

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

warface1234455
Copy link
Contributor

@warface1234455 warface1234455 commented Dec 10, 2024

Document the changes in your pull request

healium now prevents body from rotting
cryo tube now prorperly heal dead body (with extra check to prevent healium duplication) to a reviable state when healium reagent exists in the body (#22133), broken by (#22188)

Why is this good for the game?

healium could prevent organs from rotting but not the entire body is whack, allowing doctors to normally defib one without the need of revival surgery (body decayed) if healium exists in the bloodstream

plus bug fix

Testing

tested on local
cryooo

Changelog

🆑
tweak: healium now prevents body from rotting
bugfix: cryo tube now prorperly heal dead body (with extra check to prevent healium duplication) to a reviable state when healium reagent exists in the body (#22133), broken by (#22188)
/:cl:

@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Dec 10, 2024
@ynot01
Copy link
Contributor

ynot01 commented Dec 14, 2024

healium now prevents body from rotting

looking at the code it seems that healium in fact reverses body rot, not just prevents it

@warface1234455
Copy link
Contributor Author

warface1234455 commented Dec 14, 2024

healium now prevents body from rotting

looking at the code it seems that healium in fact reverses body rot, not just prevents it

Yeah maybe i have used the wrong word, but the point is allowing defib to work with rot body, if its at defib able state and with healium inside

@ynot01
Copy link
Contributor

ynot01 commented Dec 14, 2024

Yeah maybe i have used the wrong word, but the point is allowing defib to work with rot body, if its at defib able state and with healium inside

change changelog to better reflect changes

@warface1234455
Copy link
Contributor Author

Yeah maybe i have used the wrong word, but the point is allowing defib to work with rot body, if its at defib able state and with healium inside

change changelog to better reflect changes

I was going to make it actually prevent rot

@warface1234455 warface1234455 marked this pull request as draft December 14, 2024 12:17
@warface1234455 warface1234455 marked this pull request as ready for review December 14, 2024 21:14
code/datums/components/rot.dm Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants