-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Food Cart UI rework #22866
Open
Scrambledeggs00
wants to merge
33
commits into
yogstation13:master
Choose a base branch
from
Scrambledeggs00:Foodcart-UI
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Food Cart UI rework #22866
+753
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yogbot-13
added
Feature
This adds new content to the game
Fix
This fixes an issue. Please link issues in fix PRs
Tweak
This PR contains changes to the game.
labels
Dec 20, 2024
Co-authored-by: Henry <omgredstone@gmail.com>
Does this fix #19482 at all? |
I haven't tested it yet, though i would assume that it doesn't. I'll try to test it today. |
I tested it and made the necessary changes to fix the bug. The fix should also work for any other food item that works similarly. |
hedgehog1029
approved these changes
Dec 27, 2024
Oblisk234
reviewed
Dec 27, 2024
Oblisk234
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
I've changed the food cart's UI from byond HTML into TGUI as it looks nicer. The new UI is broken up into two parts: food and drinks.
Food Tab
Drink Tab
The UI also has info tooltips to explain certain UI elements. Simply hover your mouse over the blue circles with a white i to see the tooltip.
Also, when destroyed, food carts will now spill their reagents. A chat warning will also be sent if either the main or mixer storages have reagents, alerting you of the spill.
Fixes #9310
Fixes #19427
Fixes #19482
Why is this good for the game?
Old UI looked bad, reagent part of carts haven't worked in awhile, and spills are funny :]
Testing
Video of cart UI:
https://www.youtube.com/watch?v=FjUYch4DA8A
Also: I changed the spill message to specify that reagents are spilling out after this video.
Wiki Documentation
Food capacity: 80
Glass capacity: 30
Drink capacity
Reagents will spill if cart is destroyed.
Changelog
🆑
rscadd: Food carts now spill their reagents upon destruction
bugfix: Food carts can now handle reagents again
tweak: Reworked food cart's UI
/:cl: