Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds alternate state to Hawaiian Skirt. #22887

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Am37000
Copy link
Contributor

@Am37000 Am37000 commented Dec 25, 2024

Basically just added a way to wear the skirt without the coconut bra.

Document the changes in your pull request

Adds an alternate state to Hawaiian Skirt.

Didn't test, but it was a simple sprite add and code change.

Why is this good for the game?

Just adds a very small amount of more variety in clothing.

Testing

Not much testing, just added a bit of code.

Spriting

1
3
4

Wiki Documentation

Don't think wiki needs to change.

Changelog

🆑
imageadd: Added alternate state to Hawaiian Skirt.
/:cl:

Basically just added a way to wear the skirt without the coconut bra.
@Am37000
Copy link
Contributor Author

Am37000 commented Dec 25, 2024

It's been a while since I've done a PR, so if something is wrong lmk and I'll fix it!

@Oblisk234
Copy link
Member

I don't think you added the sprites to the PR?

@Am37000
Copy link
Contributor Author

Am37000 commented Dec 27, 2024

I added the sprites to the same place the original was and added a _d at the end, so idk if thats supposed to show up here.

@Oblisk234
Copy link
Member

I added the sprites to the same place the original was and added a _d at the end, so idk if thats supposed to show up here.

Did you click save?

@Am37000
Copy link
Contributor Author

Am37000 commented Dec 27, 2024

Good question!

@Am37000
Copy link
Contributor Author

Am37000 commented Dec 27, 2024

Would it umm... be easy to add it from here?

@Oblisk234
Copy link
Member

Oblisk234 commented Dec 27, 2024

Would it umm... be easy to add it from here?

Not from github no (from what I know at least), you'd likely need to open up the dme and import it to the file from there.

@Am37000
Copy link
Contributor Author

Am37000 commented Dec 27, 2024

Yeah the dme file looks good... not sure why it didn't save.

I'll try to import it.

@Am37000
Copy link
Contributor Author

Am37000 commented Dec 27, 2024

If I take the file and commit it, will that add it here?

@Oblisk234
Copy link
Member

If I take the file and commit it, will that add it here?

Once you import it through the dme and save, it'll make changes to the respective file. That is what you want to commit. (Should be in the yogstation/icons folder)

Yeah I forgot to add the sprites ig.
@Am37000
Copy link
Contributor Author

Am37000 commented Dec 27, 2024

When I click it it shows up in dme... I can dm you the file on discord if you wanna take a quick check.

@Oblisk234
Copy link
Member

When I click it it shows up in dme... I can dm you the file on discord if you wanna take a quick check.

Sure, will try to help.

@Am37000
Copy link
Contributor Author

Am37000 commented Dec 27, 2024

Sent to Obelisk2106, thats you right?

@Am37000 Am37000 requested a review from a team as a code owner December 30, 2024 01:38
Copy link
Contributor

@Mqiib Mqiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it's literally just removal of the coconuts on the alt sprite I see no issue

@github-actions github-actions bot added the Sprites This PR has spriting changes label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites This PR has spriting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants