[DONT MERGE] [#240] Improve cli ux and add cli example / docs #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ieugen
commented
Oct 31, 2023
ieugen
commented
- BREAKING? Enhanced Store protocol with close alias for disconnect
- BREAKING? connect now returns the store (this)
- create (migration) fn now resolves absolute file path for migration
- Enhanced docs for Store protocol
- CLI can load config from file
- CLI can load config from env
- CLI can load config from cli args
- CLI merges configs in this order: file, env, args
- Added some tests for CLI parsing
- Added status command, to display migration status:
- connection info - so we know which server we are connecting to
- migrations directory - so we know where we get migrations from
- the latest applied migration
- the list of not-applied migrations
- any migrations applied and not present ?!
ieugen
force-pushed
the
cli-improve
branch
2 times, most recently
from
8907a61 to
fec8a48
Compare
yogthos
reviewed
Nov 4, 2023
ieugen
force-pushed
the
cli-improve
branch
3 times, most recently
from
3c3c4b3 to
3af6f4f
Compare
|
As of now, I don't recommend using this change since migratus migrate applied some down migration in our dev db. |
* BREAKING? Enhanced Store protocol with close alias for disconnect * BREAKING? connect now returns the store (this) * create (migration) fn now resolves absolute file path for migration * Enhanced docs for Store protocol * CLI can load config from file * CLI can load config from env * CLI can load config from cli args * CLI merges configs in this order: file, env, args * Added some tests for CLI parsing * Added status command, to display migration status: - connection info - so we know which server we are connecting to - migrations directory - so we know where we get migrations from - the latest applied migration - the list of not-applied migrations - any migrations applied and not present ?!
* Implemnted status command that works mostly like list
yogthos
approved these changes
Jan 5, 2025
|
Overall looks good, ping me when you feel it's good to merge. |
|
Hi, It's not done yet. I plan to move to https://github.com/lambdaisland/cli . I also plan to do some thorough testing in a project. |
|
Oh yeah moving to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.