Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONT MERGE] [#240] Improve cli ux and add cli example / docs #252

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ieugen
Copy link
Collaborator

@ieugen ieugen commented Oct 31, 2023

  • BREAKING? Enhanced Store protocol with close alias for disconnect
  • BREAKING? connect now returns the store (this)
  • create (migration) fn now resolves absolute file path for migration
  • Enhanced docs for Store protocol
  • CLI can load config from file
  • CLI can load config from env
  • CLI can load config from cli args
  • CLI merges configs in this order: file, env, args
  • Added some tests for CLI parsing
  • Added status command, to display migration status:
    • connection info - so we know which server we are connecting to
    • migrations directory - so we know where we get migrations from
    • the latest applied migration
    • the list of not-applied migrations
    • any migrations applied and not present ?!

@ieugen ieugen self-assigned this Oct 31, 2023
@ieugen ieugen requested a review from yogthos October 31, 2023 22:06
@ieugen ieugen force-pushed the cli-improve branch 2 times, most recently from 8907a61 to fec8a48 Compare October 31, 2023 22:18
@ieugen ieugen force-pushed the cli-improve branch 3 times, most recently from 3c3c4b3 to 3af6f4f Compare November 6, 2023 14:28
@ieugen
Copy link
Collaborator Author

ieugen commented Nov 13, 2023

As of now, I don't recommend using this change since migratus migrate applied some down migration in our dev db.
Don't know why, will investigate.

* BREAKING? Enhanced Store protocol with close alias for disconnect
* BREAKING? connect now returns the store (this)
* create (migration) fn now resolves absolute file path for migration
* Enhanced docs for Store protocol
* CLI can load config from file
* CLI can load config from env
* CLI can load config from cli args
* CLI merges configs in this order: file, env, args
* Added some tests for CLI parsing
* Added status command, to display migration status:
  - connection info - so we know which server we are connecting to
  - migrations directory - so we know where we get migrations from
  - the latest applied migration
  - the list of not-applied migrations
  - any migrations applied and not present ?!
* Implemnted status command that works mostly like list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants