Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding functionality to unsubscribe from events. #95

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

infiniteyak
Copy link
Contributor

I had to use reflect to compare the subscribers. Otherwise you get an error saying you can only compare functions to nil.

@yohamta yohamta merged commit 7bf72f0 into yohamta:main Dec 29, 2022
@yohamta
Copy link
Owner

yohamta commented Dec 29, 2022

@infiniteyak Thank you for submitting the PR!
I didn't realize that pointers to a function cannot be compared each other in Go, so I am grateful to have learned something new 🙂
Your work looks great and I appreciate your attention to detail. Thank you again for your contribution!
This change is now available in version v1.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants