chore: update to joi 16.x.x #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-div
commented
Nov 13, 2019
g-div
commented
Nov 13, 2019
Closed
yoitsro
reviewed
Nov 26, 2019
|
Hey @g-div! Have you had a chance to take a look at my comments yet? |
Sorry! Very busy at the moment, I will take a look at it as soon as possible. |
|
No worries at all @g-div! Just wanted to make sure you'd seen my comments :) Thank you for your work on this so far 🙏 |
|
Nice! Good work. Thank you! I'll get it merged and released shortly! |
yoitsro
pushed a commit
that referenced
this pull request
Dec 11, 2019
BREAKING CHANGE: Update to joi 16.x.x. Optimise for validations which are synchronous. Closes #27
musilon9
pushed a commit
to musilon9/via-multidict-server
that referenced
this pull request
Dec 19, 2019
IMPORTANT: This will not work until new release of joigoose with yoitsro/joigoose#29 merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #27
It passes all the tests, but there are some lines I'm not sure they are producing the same effect as before...