Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show error message if duplicate sfn name #582

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Aug 24, 2023

Description

Data stream links their connections, ff two identical named sfn are connected to the same zipper, then the preceding sfn should be closed.

@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
yomo ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2023 8:42am

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #582 (bf8acd5) into master (8d4eddf) will decrease coverage by 0.26%.
The diff coverage is 59.23%.

@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
- Coverage   63.31%   63.06%   -0.26%     
==========================================
  Files          39       40       +1     
  Lines        2988     3097     +109     
==========================================
+ Hits         1892     1953      +61     
- Misses        963     1004      +41     
- Partials      133      140       +7     
Files Changed Coverage Δ
core/client.go 70.68% <0.00%> (-1.68%) ⬇️
pkg/frame-codec/y3codec/rejected_frame.go 72.72% <ø> (+0.85%) ⬆️
core/control_stream.go 59.77% <52.38%> (-0.78%) ⬇️
core/data_stream.go 64.13% <57.14%> (-35.87%) ⬇️
pkg/frame-codec/y3codec/goaway_frame.go 72.72% <72.72%> (ø)
core/stream_group.go 75.55% <100.00%> (+0.27%) ⬆️
pkg/frame-codec/y3codec/codec.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

core/stream_group.go Outdated Show resolved Hide resolved
core/client.go Outdated Show resolved Hide resolved
@woorui woorui merged commit 4db38f5 into master Sep 6, 2023
3 of 5 checks passed
@woorui woorui deleted the fix/same-name-sfn branch September 6, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants