-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building for architectures other than x86_64 on macOS (Apple Silicon) #185
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5ec9d11
Add and test new 'ProfileInfo.machineHardwareName' property
liamnichols 11f3903
Update 'Mint.install(package:executable:beforeOtherCommand:force:link…
liamnichols 91dcb52
Remove use of XCTSkipIf to preserve support for Xcode 10.2
liamnichols 4bafba7
Update CHANGELOG.md
liamnichols 05fc39f
Clean up ProcessInfoExtensionTests by removing print for skipped tests
liamnichols File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import Foundation | ||
|
||
extension ProcessInfo { | ||
/// Returns a `String` representing the machine hardware name or nil if there was an error invoking `uname(_:)` or decoding the response. | ||
/// | ||
/// Return value is the equivalent to running `$ uname -m` in shell. | ||
var machineHardwareName: String? { | ||
var sysinfo = utsname() | ||
let result = uname(&sysinfo) | ||
guard result == EXIT_SUCCESS else { return nil } | ||
|
||
let data = Data(bytes: &sysinfo.machine, count: Int(_SYS_NAMELEN)) | ||
|
||
guard let identifier = String(bytes: data, encoding: .ascii) else { return nil } | ||
return identifier.trimmingCharacters(in: .controlCharacters) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
@testable import MintKit | ||
import XCTest | ||
|
||
final class ProcessInfoExtensionTests: XCTestCase { | ||
#if arch(x86_64) | ||
func testMachineHardwareName_Intel() { | ||
XCTAssertEqual(ProcessInfo.processInfo.machineHardwareName, "x86_64") | ||
} | ||
#endif | ||
|
||
#if arch(arm64) | ||
func testMachineHardwareName_AppleSilicone() { | ||
XCTAssertEqual(ProcessInfo.processInfo.machineHardwareName, "arm64") | ||
} | ||
#endif | ||
} | ||
Comment on lines
+4
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if there is a better way to test this.. While we only need for I was going to use |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if I am being too strict here? Could this be non-optional and either just force unwrap or return an empty string in the (unlikely) event of a failure?