Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build executables one by one #256

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

vincentisambart
Copy link
Contributor

closes #255

The changes in #251 add each executable target as an additional --product \(executable) to the swift build command. Unfortunately, when multiple products are specified with --product \(executable), swift build does not build all of them, only the last one.

swift build does not seem to have a way to explicitly specify multiple products to build at once, so instead this PR makes Mint run swift build once for each executable product.

@vincentisambart
Copy link
Contributor Author

@yonaskolb Could you please have a look?

Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for both the report and the fix @vincentisambart!

@yonaskolb yonaskolb merged commit 526f662 into yonaskolb:master Dec 22, 2022
@vincentisambart vincentisambart deleted the build-each-executable branch December 22, 2022 05:56
@vincentisambart
Copy link
Contributor Author

Thanks for the review and release 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install IBLinter with latest Mint
2 participants