Don't add PBXContainerItemProxy when reusing PBXReferenceProxy
#1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On a side note, I became aware of this because we use R.swift in our project, which uses XcodeEdit, which has a validator to check for orphaned object references in the project file: I wonder if it would be beneficial/possible for XcodeGen to perform a similar validation 🤔 Either just in the unit tests, or maybe even at runtime |
yonaskolb
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Nice one, thank you @liamnichols! 🙏 Could you please add a CHANGELOG fix entry as well
yonaskolb
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1354 (comment)
In an unrelated test, I spotted that the recent changes in #1354 were mistakenly creating orphaned
PBXContainerItemProxyobjects in the project file. This change updates the fixture tests to reproduce the issue and applies a patch (check out the individual commits to see the impact).