-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Strings Catalogs (Xcode 15) #1421
Support for Strings Catalogs (Xcode 15) #1421
Conversation
…t asset catalogs are added in the resources build phase
@@ -163,6 +163,7 @@ targets: | |||
resourceTags: | |||
- tag1 | |||
- tag2 | |||
- String Catalogs/Localizable.xcstrings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems not following the naming pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
I'm suggesting to add more documentation about this change and also, review the naming pattern for the arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thank you @nicolasbosi95!
Xcode 15 introduced String Catalogs (
.xcstrings
files), which intend to replace the now legacy.strings
andstringsdict
files.These changes add support to strings catalogs in the following ways:
text.json.xcstring
.knownRegions
of the project. This is because string catalogs do not reside in dedicated per-locale.lproj
directories, so detectingknownRegions
exclusively based on existing.lproj
directories is no longer reliable.