Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash bundle #1448

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Fix crash bundle #1448

merged 2 commits into from
Feb 15, 2024

Conversation

freddi-kit
Copy link
Collaborator

Closes #1445

This will fix crash on loading bundle if xcodegen is not artifact bundle binary

@freddi-kit
Copy link
Collaborator Author

freddi-kit commented Feb 15, 2024

@yonaskolb I'm sorry this is a little urgent for everyone, so could you help checking it?

Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, have you tested it @freddi-kit?

@freddi-kit
Copy link
Collaborator Author

I tested and works well

@yonaskolb yonaskolb merged commit 5bcbf39 into master Feb 15, 2024
4 checks passed
@yonaskolb yonaskolb deleted the fix-crash-bundle branch February 15, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XcodeGenKit/resource_bundle_accessor.swift:44: Fatal error: unable to find bundle named XcodeGen_XcodeGenKit
2 participants