Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getGarbageLength to return correct size #145

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Conversation

skhugh
Copy link
Contributor

@skhugh skhugh commented Jan 15, 2024

What this PR does / why we need it?

Fix getGarbageLength to return correct size

Any background context you want to provide?

What are the relevant tickets?

yorkie-team/yorkie-js-sdk#714

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@skhugh skhugh self-assigned this Jan 15, 2024
@skhugh skhugh requested review from 7hong13 and hackerwins January 15, 2024 10:14
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (632aa5d) 78.33% compared to head (d32dddf) 78.47%.
Report is 2 commits behind head on main.

Files Patch % Lines
...orkie/src/main/kotlin/dev/yorkie/util/IndexTree.kt 42.30% 11 Missing and 4 partials ⚠️
...c/main/kotlin/dev/yorkie/document/crdt/CrdtRoot.kt 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   78.33%   78.47%   +0.13%     
==========================================
  Files          63       63              
  Lines        3721     3744      +23     
  Branches      582      582              
==========================================
+ Hits         2915     2938      +23     
  Misses        500      500              
  Partials      306      306              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skhugh
Copy link
Contributor Author

skhugh commented Jan 16, 2024

FYI, I've changed instrumentation test to run on a single device as it was failing too often

@skhugh skhugh merged commit 99713c1 into yorkie-team:main Jan 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants