Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle concurrent editing and styling in Tree #803

Merged
merged 3 commits into from
May 9, 2024

Conversation

raararaara
Copy link
Contributor

@raararaara raararaara commented May 8, 2024

What this PR does / why we need it?

Handle concurrent editing and styling in Tree

We will use maxCreatedAtMapByActor until the introduction of
VersionVector. yorkie-team/yorkie#800

Any background context you want to provide?

What are the relevant tickets?

Related yorkie-team/yorkie#854

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 93.87755% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.68%. Comparing base (ba635e6) to head (7dc48e5).

Files Patch % Lines
src/document/crdt/tree.ts 90.90% 0 Missing and 2 partials ⚠️
src/document/crdt/rga_tree_split.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   80.50%   80.68%   +0.17%     
==========================================
  Files          59       59              
  Lines        4448     4468      +20     
  Branches      901      906       +5     
==========================================
+ Hits         3581     3605      +24     
+ Misses        605      601       -4     
  Partials      262      262              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins
Copy link
Member

💪

@hackerwins hackerwins marked this pull request as ready for review May 8, 2024 23:37
@hackerwins hackerwins self-requested a review May 8, 2024 23:38
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit e086ad7 into main May 9, 2024
2 checks passed
@hackerwins hackerwins deleted the concurrent-tree-style branch May 9, 2024 00:38
@hackerwins hackerwins mentioned this pull request May 29, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants