-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove panics in 'to protobuf' logic of the converter #135
Conversation
If an error occurs in the converter, the converter must return an error and allow the caller to decide how to handle it.
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 62.25% 61.96% -0.29%
==========================================
Files 26 26
Lines 2673 2758 +85
==========================================
+ Hits 1664 1709 +45
- Misses 860 882 +22
- Partials 149 167 +18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work. 👍 I left two types of comments.
- Whether
fmt.Errorf
is properly formatted. - Apply
pbXXX
name to protobuf message.
@hackerwins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍 Thanks for contributing.
If an error occurs in the converter, the converter must return an error and allow the caller to decide how to handle it.
What this PR does / why we need it:
If an error occurs in the converter, the converter must return an error
and allow the caller to decide how to handle it.
Which issue(s) this PR fixes:
Fixes #50
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: