Use Xid instead of UUID for SubscriptionID #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before implementing the distributed PubSub implementation using ETCD, we need to extract the temporarily implemented MemoryPubSub and leave only the high-level abstraction logic in PubSub.
Xid smaller than UUID(12bytes) and it's sortable. It is useful if the SubscriptionID can be sortable.
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
=======================================
Coverage 58.59% 58.59%
=======================================
Files 27 27
Lines 2968 2968
=======================================
Hits 1739 1739
Misses 1056 1056
Partials 173 173 Continue to review full report at Codecov.
|
jeonjonghyeok
pushed a commit
to jeonjonghyeok/yorkie
that referenced
this pull request
Aug 4, 2022
Xid(12bytes) smaller than UUID and it's sortable. It is useful if the SubscriptionID can be sortable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use Xid instead of UUID for SubscriptionID
Xid(12bytes) smaller than UUID and it's sortable. It is useful if the
SubscriptionID can be sortable.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
We need to merge #141 first.
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: