Akia code patch makefile #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clean up the checkpoint-related codes * Remove docker-compose-ci.yml * Calculate `minSyncedTicket` based on `time.Ticket` not `serverSeq` `serverSeq` is used to calculate changes between client and server. Since serverSeq is not a logical clock, it cannot be used to find the minimum value of a ticket. This commit calculates `minSyncedTicket` based on the value of `time.Ticket`, `lamport` and `actorID`.
hackerwins
force-pushed
the
AkiaCode-patch-makefile
branch
from
4f28f2e to
9f80b53
Compare
…nto AkiaCode-patch-makefile
hackerwins
force-pushed
the
AkiaCode-patch-makefile
branch
from
9f80b53 to
729e734
Compare
Codecov Report
@@ Coverage Diff @@
## main #295 +/- ##
==========================================
- Coverage 48.95% 48.88% -0.08%
==========================================
Files 59 59
Lines 4757 4764 +7
==========================================
Hits 2329 2329
- Misses 2166 2173 +7
Partials 262 262
Continue to review full report at Codecov.
|
jeonjonghyeok
pushed a commit
to jeonjonghyeok/yorkie
that referenced
this pull request
Aug 4, 2022
Co-authored-by: Akiacode <catry.me@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: