Extract Admin Server #311
Merged
Extract Admin Server #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerwins
force-pushed
the
extract-admin-server
branch
from
a27c6f0 to
6db91a9
Compare
Admin Server needs to be handled by a different auth mechanism. It also has to handle different workloads than RPC. So this commit extract Admin Server from RPC Server.
hackerwins
force-pushed
the
extract-admin-server
branch
from
6db91a9 to
41f974a
Compare
Codecov Report
@@ Coverage Diff @@
## main #311 +/- ##
=======================================
Coverage 48.06% 48.07%
=======================================
Files 60 59 -1
Lines 4904 4903 -1
=======================================
Hits 2357 2357
+ Misses 2287 2285 -2
- Partials 260 261 +1
Continue to review full report at Codecov.
|
2 tasks
jeonjonghyeok
pushed a commit
to jeonjonghyeok/yorkie
that referenced
this pull request
Aug 4, 2022
Admin Server needs to be handled by a different auth mechanism. It also has to handle different workloads than RPC. So this commit extract Admin Server from RPC Server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Extract Admin Server
Admin Server needs to be handled by a different auth mechanism. It also
has to handle different workloads than RPC.
So this commit extract Admin Server from RPC Server.
Which issue(s) this PR fixes:
Address #273
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: