Use document ID instead of key for watchDocuments API #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 48.79% 48.68% -0.12%
==========================================
Files 69 69
Lines 5962 5953 -9
==========================================
- Hits 2909 2898 -11
- Misses 2712 2714 +2
Partials 341 341
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hackerwins
force-pushed
the
watch-doc-id
branch
from
dadd2ec to
b1c84ff
Compare
hackerwins
force-pushed
the
watch-doc-id
branch
from
03f2f23 to
4507086
Compare
hackerwins
force-pushed
the
watch-doc-id
branch
from
02d47ee to
2285241
Compare
…into watch-doc-id
hackerwins
approved these changes
Mar 17, 2023
hackerwins
pushed a commit
that referenced
this pull request
Mar 17, 2023
1. Change to use ID instead of Key in WatchDocument
- By introducing RemoveDocument API, multiple IDs can be mapped to a
single key(multiple removed IDs and one active ID)
2. Change WatchDocuments API to WatchDocument API
- In the cluster mode conversion task, one document is mapped to one
server, and single document mapping is a simplified cluster
- This can cause Changing the structure where the client maintains
one WatchDocuments stream to maintain multiple streams.
3. Remove unnecessary types due to the change in step 2
- The implementation was simplified by changing the structure in
step 2, so unnecessary data types were cleaned up.
Co-authored-by: hackerwins <hackerwins@gmail.com>
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Address: #484
Which issue(s) this PR fixes:
Fixes #487
Related to #464
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: