Handle error responses from the token requests #319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the token source tries to parse a response into a token even if the response was not successful.
This makes it difficult to debug what was the actual error cause, as the token source fails with an error like this:
while the actual response can for example be a HTTP 400 Bad Request with a body like this:
The full list of possible error codes can be found here: https://developers.google.com/identity/protocols/oauth2/service-account#error-codes
This PR adds a check for the response status, and tries to parse the error response.