This repository has been archived by the owner on Nov 19, 2019. It is now read-only.
Fixes issue #63 - Reordering items not working correctly #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #63. This main bug is caused when the target of the groupDrag event is the
group.dom.inner
element since thegroup.setData
method is called which removes thegroup.dom.inner
element completely and thus the reference to the drag element is lost and the group stops dragging.group.setData
method if there is a group being dragged.timeline-group-is-dragging
to thegroup.dom.label
andgroup.dom.foreground
elements of the dragged group while it is being dragged and removes it on the drag end event.groupsEditable.html
example to confirm that the bug is fixed.PS. Lines 1919-1973 in the
_onGroupDrag
method and lines 1996-2034 in_onGroupDragEnd
method of ItemSet.js dont appear to do anything.