Improve Settings UI/UX #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, two scrolls would occur creating a complicated user experience. This commit solves the issue by inlining EnginePref into the LazyColumn. A problem occurs in which BlockingRadioButton causes a crash due to infinite height mechanics of LazyVerticalGrid. To solve this, a max height of 200.dp is applied to LazyVerticalGrid.
Helps make the dialog easier to understand. Solved by adding an optional parameter to ListPreferenceDialog for a title.
Clarifies what is currently being used. Solved by adding an optional isSelected parameter to ListPreferenceOption & SelectableItem.
|
@Bnyro Currently TessSettings is done via dialog and is a tad claustrophobic. I will leave it out of this PR, as I feel like it is a different scope. But the Tess Helper and Settings can be improved. Such as proper language titles, descriptions, file sizes, etc. |
|
@Doomsdayrs Yes, I'm aware, I didn't do that at the initial implementation because I was kinda lazy. |
Ah, I feel the same sometimes, easier to just get something bare metal in then all the extra effort xD. |
The issue was that 250.dp was just empty for no apparent reason. By instead having the picker disabled and at half alpha, the user can see what is the other option. This is resolved by using animateFloatAsState to control the alpha, and adding a pointer input override.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few issues I found with the UI/UX of the settings view. This PR aims to solve those issues.