Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating support for _.groupBy() using Object.groupBy() #387

Closed
wants to merge 1 commit into from
Closed

Updating support for _.groupBy() using Object.groupBy() #387

wants to merge 1 commit into from

Conversation

ryohidaka
Copy link

@ryohidaka ryohidaka commented Dec 2, 2023

Overview

Update the sample codes for _groupBy as Object.groupBy() is now natively supported.

Notes

  • Safari currently supports Object.groupBy() in Technical Preview (TP). However, as it is not part of an official release, it is marked as unsupported (x) in this PR.
  • Please note that not all browsers have added support for this feature. Therefore, we need to discuss whether to include it or not.

Links

@ryohidaka ryohidaka changed the title Add Object.groupBy() to Collection _.groupBy Updating support for _.groupBy() using Object.groupBy() Dec 2, 2023
@binury
Copy link

binury commented Apr 13, 2024

this is conflicted upstream due to #390 which (despite having been submitted weeks later) implements basically these same changes… Sorry @ryohidaka 😞 @ODudek

@ryohidaka
Copy link
Author

@binury

Thank you for contacting me.
Since you said that Object.groupBy() has already been updated, I will close the pull request without addressing the conflict here.

@ryohidaka ryohidaka closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants