Change labels in point_plotter.py

[janderson4]

Summary by Sourcery

Enhancements:

• Adjust label offset logic in point_plotter.py to improve label positioning.

[sourcery-ai]

Reviewer's Guide by Sourcery

The changes improve the label positioning in the point plotter by separating the x and y offset calculations and adjusting the vertical positioning of labels based on their location. This makes the plot more readable by preventing label overlap.

Class diagram for label offset changes in point_plotter.py

classDiagram
    class PointPlotter {
        +plot(capacity_pts, point: LoadCombination | None, only_Mx)
    }

    PointPlotter : -label_offset_x
    PointPlotter : -label_offsets_y
    PointPlotter : +plot()

    note for PointPlotter "Updated label offset calculations for x and y axes"

Loading

File-Level Changes

Change	Details	Files
Refactored label offset calculation for better label positioning	Split single label_offsets tuple into separate x and y offset variables Modified y-axis offset to use different values for top and bottom labels Updated label positioning logic to use position-dependent y-offset Increased negative y-offset for bottom labels to -5% of load span (from +2%)	examples/conc_col_pmm/calc_document/plotting/point_plotter.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @janderson4 - I've reviewed your changes - here's some feedback:

Overall Comments:

• There's a bug in the point plotting section - the variable 'i' is undefined when determining label_offset_y. You'll need to use a different condition to determine whether to use the top or bottom offset.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[youandvern]

I committed the changes directly for this one. We'll probably want to clean up your repo git history and use branches for future PRs