YSHOP2-1133: Add ResourcePicker component #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eihabkhan1
added
💻 Ready for review
eihabkhan1
commented
Dec 14, 2023
packages/vue3/package.json
Outdated
There was a problem hiding this comment.
Bumped vue to add support for external types import in SFC (ref: vuejs/core#8083)
eihabkhan1
added
⏳ in progress
eihabkhan1
added
💻 Ready for review
AliHMIMS
reviewed
Dec 25, 2023
Comment on lines
19
to
22
| function handleCheck(e: Event) { | ||
| const res: Resource = { ...props.resource }; | ||
| emit('change', e, res); | ||
| } |
There was a problem hiding this comment.
Suggested change
| function handleCheck(e: Event) { | |
| const res: Resource = { ...props.resource }; | |
| emit('change', e, res); | |
| } | |
| function handleCheck(e: Event) { | |
| emit('change', e, props.resource); | |
| } |
Comment on lines
25
to
26
| <template> | ||
| <Checkbox v-model="model" class="container" :class="!showThumbnail && 'variant'" :indeterminate="$props.indeterminate" @change.stop="handleCheck"> |
There was a problem hiding this comment.
Wouldn't this work?
Suggested change
| <template> | |
| <Checkbox v-model="model" class="container" :class="!showThumbnail && 'variant'" :indeterminate="$props.indeterminate" @change.stop="handleCheck"> | |
| <template> | |
| <Checkbox v-model="model" class="container" :class="!showThumbnail && 'variant'" :indeterminate="indeterminate" @change.stop="handleCheck"> |
AliHMIMS
approved these changes
Dec 25, 2023
AliHMIMS
added
✅ Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
YSHOP2-1133
QA Steps
pnpm installhttp://localhost:3000/