Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for recursive mount attrs #1534

Open
17 of 18 tasks
higuruchi opened this issue Feb 1, 2023 · 5 comments · May be fixed by #2658
Open
17 of 18 tasks

Test for recursive mount attrs #1534

higuruchi opened this issue Feb 1, 2023 · 5 comments · May be fixed by #2658
Labels
good first issue Good for newcomers

Comments

@higuruchi
Copy link
Contributor

higuruchi commented Feb 1, 2023

Add test for recursive mount attrs option implemented in #1398.

  • rro
  • rrw
  • rnosuid
  • rsuid
  • rnodev
  • rdev
  • rnoexec
  • rexec
  • rnodiratime
  • rdiratime
  • rrelatime
  • rnorelatime
  • rnoatime
  • ratime
  • rstrictatime
  • rnostrictatime
  • rnosymfollow
  • rsymfollow
@lengrongfu
Copy link
Collaborator

lengrongfu commented Mar 6, 2023

currently completed part.

  • rro
  • rrw
  • rnosuid
  • rsuid
  • rnodev
  • rdev
  • rnoexec
  • rexec
  • rnodiratime
  • rdiratime
  • rrelatime
  • rnorelatime
  • rnoatime
  • ratime
  • rstrictatime
  • rnostrictatime
  • rnosymfollow
  • rsymfollow

@utam0k
Copy link
Collaborator

utam0k commented Mar 7, 2023

@lengrongfu I have updated! Thanks for your kind reminder.

@CreepyPvP
Copy link
Contributor

Hi, id like to contribute to this issue. What tests are still open (and because iam new to this project / container runtimes in general a good point to get started)?

@utam0k
Copy link
Collaborator

utam0k commented May 16, 2023

@CreepyPvP How about ratime or rsymfollow?

@CreepyPvP
Copy link
Contributor

CreepyPvP commented May 17, 2023

Hi, iam currently adding a test for ratime. I keep getting this error while creating container:

ERROR libcontainer::process::container_init_process: failed to prepare rootfs err=Mount(Syscall(MountSetattr { source: EINVAL }))
ERROR libcontainer::process::container_intermediate_process: failed to initialize container process: failed to prepare rootfs
ERROR libcontainer::process::container_main_process: failed to wait for init ready: failed to receive. "waiting for init ready". BrokenChannel
ERROR youki: error in executing command: failed to create container

The error does not appear if ratime doesn't get set or gets cleared. I modified the check_recursive_rnoatime test to set ratime instead, tho it then starts failing as well.

The MOUNT_ATTR__ATIME seems to get set correctly toattr_clr and i could not find another reason for an EINVAL according to this https://man7.org/linux/man-pages/man2/mount_setattr.2.html.

Maybe I missed something.
Here is the test i've been running: https://github.com/CreepyPvP/youki/tree/atime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants