Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rsuid and rnosymfollow #1685

Merged

Conversation

lengrongfu
Copy link
Collaborator

issue: #1534

  • rsuid
  • rnosymfollow

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Merging #1685 (0fec613) into main (4015e9e) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1685   +/-   ##
=======================================
  Coverage   68.77%   68.78%           
=======================================
  Files         121      121           
  Lines       13295    13295           
=======================================
+ Hits         9144     9145    +1     
+ Misses       4151     4150    -1     

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Mar 20, 2023

Hey @lengrongfu , Thanks a lot for this! I haven't taken a detailed look, but I had a general question :

You have worked a lot with this part, and implemented several of these mount attr tests. Do you think we can refactor the test logic? What I mean is that is there a common "pattern" in all mount attr tests, that can be extracted in a function and then each individual attr test call this function ; so that individual attr test functions become simpler?

And this is by no means a request to do it in this PR. If that can be done, we might first implement all the tests and then do that in a separate PR. I am just curious to know if that might be possible or not.

Thanks :)

@lengrongfu
Copy link
Collaborator Author

I think it is possible, I create a refactoring issue.

@lengrongfu lengrongfu force-pushed the feat/rrelatime_recursive_mount_test branch from 07c3548 to 0fec613 Compare March 22, 2023 05:56
@lengrongfu lengrongfu force-pushed the feat/rrelatime_recursive_mount_test branch from 0fec613 to 1707123 Compare March 22, 2023 14:23
Signed-off-by: lengrongfu <1275177125@qq.com>
@lengrongfu lengrongfu force-pushed the feat/rrelatime_recursive_mount_test branch from 1707123 to 504b3d0 Compare March 22, 2023 14:27
Copy link
Collaborator

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lengrongfu Thanks!

@utam0k utam0k merged commit 3fd810e into youki-dev:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants