-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(integration_test): port 'runtime-tools/validation/linux_seccomp' #2531
Conversation
Signed-off-by: Xiaoyang Liu <siujoeng.lau@gmail.com>
Hey, the CI is passing, and overall seems ok. I'll take a more detailed look a bit later, but should be fine with one-two nitpicks. |
No problem! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, overall good, just minor nitpicks, good to go after those are fixed 👍
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
==========================================
+ Coverage 65.87% 65.91% +0.03%
==========================================
Files 133 133
Lines 16868 16873 +5
==========================================
+ Hits 11112 11122 +10
+ Misses 5756 5751 -5 |
Co-authored-by: Yashodhan <54112038+YJDoc2@users.noreply.github.com> Signed-off-by: Xiaoyang Liu <siujoeng.lau@gmail.com>
Signed-off-by: Xiaoyang Liu <siujoeng.lau@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contributions : )
#361
This pull request ports the
runtime-tools/validation/linux_seccomp
test case totests/integration_test/src/tests/seccomp/mod.rs
.