Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration_test): port 'runtime-tools/validation/linux_seccomp' #2531

Merged
merged 3 commits into from
Nov 17, 2023
Merged

test(integration_test): port 'runtime-tools/validation/linux_seccomp' #2531

merged 3 commits into from
Nov 17, 2023

Conversation

xiaoyang-sde
Copy link
Contributor

#361

This pull request ports the runtime-tools/validation/linux_seccomp test case to tests/integration_test/src/tests/seccomp/mod.rs.

Signed-off-by: Xiaoyang Liu <siujoeng.lau@gmail.com>
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Nov 15, 2023

Hey, the CI is passing, and overall seems ok. I'll take a more detailed look a bit later, but should be fine with one-two nitpicks.
Thanks a lot for contributing!

@xiaoyang-sde
Copy link
Contributor Author

Hey, the CI is passing, and overall seems ok. I'll take a more detailed look a bit later, but should be fine with one-two nitpicks. Thanks a lot for contributing!

No problem! 👍

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, overall good, just minor nitpicks, good to go after those are fixed 👍

tests/integration_test/src/tests/seccomp/mod.rs Outdated Show resolved Hide resolved
tests/runtimetest/src/tests.rs Outdated Show resolved Hide resolved
tests/integration_test/src/tests/seccomp/mod.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Merging #2531 (c0b1539) into main (7b4160a) will increase coverage by 0.03%.
Report is 11 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2531      +/-   ##
==========================================
+ Coverage   65.87%   65.91%   +0.03%     
==========================================
  Files         133      133              
  Lines       16868    16873       +5     
==========================================
+ Hits        11112    11122      +10     
+ Misses       5756     5751       -5     

xiaoyang-sde and others added 2 commits November 16, 2023 21:14
Co-authored-by: Yashodhan <54112038+YJDoc2@users.noreply.github.com>
Signed-off-by: Xiaoyang Liu <siujoeng.lau@gmail.com>
Signed-off-by: Xiaoyang Liu <siujoeng.lau@gmail.com>
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contributions : )

@YJDoc2 YJDoc2 merged commit 18f3dd7 into youki-dev:main Nov 17, 2023
14 checks passed
@xiaoyang-sde xiaoyang-sde deleted the linux_seccomp branch November 17, 2023 15:43
This was referenced Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants