Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init a seccomp project #2729

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Init a seccomp project #2729

merged 2 commits into from
Apr 4, 2024

Conversation

utam0k
Copy link
Collaborator

@utam0k utam0k commented Mar 16, 2024

This is an experimental crate. I'll implement a seccomp crate step-by-step.
When it is mature, I'll move it under the crate/ and use it instead of libseccomp.

ref: #2724

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

Merging #2729 (3266094) into main (ed2c08d) will not change coverage.
Report is 28 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2729   +/-   ##
=======================================
  Coverage   65.21%   65.21%           
=======================================
  Files         133      133           
  Lines       16981    16981           
=======================================
  Hits        11074    11074           
  Misses       5907     5907           

@utam0k utam0k added the kind/experimental `/experimental` label Mar 16, 2024
@utam0k utam0k force-pushed the seccomp branch 2 times, most recently from 3a0d39b to 7b848bf Compare March 16, 2024 07:23
Signed-off-by: utam0k <k0ma@utam0k.jp>
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Mar 18, 2024

I'll try to take a look at this later today 👍

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, great as a starting point! I have left some comments, which we might want to consider, but we can consider them in later commits, this is good to go, so approving.

Also, eventually when we have enough of lib ready, we should consider portin https://github.com/seccomp/libseccomp/tree/main/tests tests over here, so we can validate our impl. I think in their CI they compile and link these tests against branch build, which in case of rust is similar to unit tests, so we should be able to use those examples as part of crate/top level unit tests.

experiment/seccomp/Cargo.toml Show resolved Hide resolved
experiment/seccomp/src/instruction/arch.rs Outdated Show resolved Hide resolved
experiment/seccomp/src/instruction/consts.rs Show resolved Hide resolved
experiment/seccomp/src/instruction/inst.rs Outdated Show resolved Hide resolved
experiment/seccomp/src/main.rs Outdated Show resolved Hide resolved
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Mar 26, 2024

@utam0k Should I go ahead and merge this?

@utam0k
Copy link
Collaborator Author

utam0k commented Mar 31, 2024

@utam0k Should I go ahead and merge this?

Thanks for your review. I'll fix them on this PR

Signed-off-by: utam0k <k0ma@utam0k.jp>
@utam0k
Copy link
Collaborator Author

utam0k commented Apr 4, 2024

@YJDoc2 Do you want to take another look?

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Can merge once the CI is done 👍

@utam0k
Copy link
Collaborator Author

utam0k commented Apr 4, 2024

@YJDoc2 Thanks for your quick review 😍

@utam0k utam0k merged commit 13d791b into youki-dev:main Apr 4, 2024
28 checks passed
@github-actions github-actions bot mentioned this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/experimental `/experimental`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants