-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init a seccomp project #2729
Init a seccomp project #2729
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2729 +/- ##
=======================================
Coverage 65.21% 65.21%
=======================================
Files 133 133
Lines 16981 16981
=======================================
Hits 11074 11074
Misses 5907 5907 |
3a0d39b
to
7b848bf
Compare
Signed-off-by: utam0k <k0ma@utam0k.jp>
I'll try to take a look at this later today 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, great as a starting point! I have left some comments, which we might want to consider, but we can consider them in later commits, this is good to go, so approving.
Also, eventually when we have enough of lib ready, we should consider portin https://github.com/seccomp/libseccomp/tree/main/tests tests over here, so we can validate our impl. I think in their CI they compile and link these tests against branch build, which in case of rust is similar to unit tests, so we should be able to use those examples as part of crate/top level unit tests.
@utam0k Should I go ahead and merge this? |
Thanks for your review. I'll fix them on this PR |
Signed-off-by: utam0k <k0ma@utam0k.jp>
@YJDoc2 Do you want to take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Can merge once the CI is done 👍
@YJDoc2 Thanks for your quick review 😍 |
This is an experimental crate. I'll implement a seccomp crate step-by-step.
When it is mature, I'll move it under the
crate/
and use it instead of libseccomp.ref: #2724