Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(libcontainer) no_pivot args is not used #2923

Merged
merged 7 commits into from
Oct 29, 2024
Merged

fix(libcontainer) no_pivot args is not used #2923

merged 7 commits into from
Oct 29, 2024
+304 −21

Commits on Sep 27, 2024

  1. Support setting no_pivot_root for create and run command 

    Signed-off-by: Vanient <xiadanni1@huawei.com>
    @Vanient @xujihui1985
    Vanient authored and xujihui1985 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    818cec8 View commit details
    Browse the repository at this point in the history

  2. fix: mount move before choot 

    Move the rootfs to the root of the host filesystem before chrooting,
this is equivalent to pivot_root, if don't move mount first, we will
not see the new rootfs when exec into the container

Signed-off-by: xujihui1985 <xujihui1985@gmail.com>
    @xujihui1985
    xujihui1985 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    65d6b54 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. fix(chroot): ensure mount occurs before chroot to mimic pivot_root be… 

    …havior

Move the mount operation to occur before calling chroot to better simulate the effect of pivot_root.
Add a check to confirm if the current process is running inside an isolated mount namespace, ensuring proper mount handling.

Signed-off-by: xujihui1985 <xujihui1985@gmail.com>
    @xujihui1985
    xujihui1985 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    79f25d5 View commit details
    Browse the repository at this point in the history

  2. implement intergration test for no-pivot 

    Signed-off-by: xujihui1985 <xujihui1985@gmail.com>
    @xujihui1985
    xujihui1985 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0f0caa5 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from xujihui1985/feat/implement-intergration-test 

    Feat/implement intergration test
    @xujihui1985
    xujihui1985 authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c82496b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. fix: add comments to no-pivot related code 

    Signed-off-by: xujihui1985 <xujihui1985@gmail.com>
    @xujihui1985
    xujihui1985 committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    6aa2ce5 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. fix(lint): fix format 

    Signed-off-by: xujihui1985 <xujihui1985@gmail.com>
    @xujihui1985
    xujihui1985 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    60f5e23 View commit details
    Browse the repository at this point in the history