-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selinux: fix xattr and remove anyhow #2936
Conversation
3d2d34a
to
e0a359b
Compare
e0a359b
to
df77c11
Compare
Hi @YJDoc2 @utam0k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey overall good, a couple of suggestions in the code, with two questions here -
- Please run clippy on local and check that all lints are passing, currently that is not getting verified in CI.
- I saw that for
EINTR
, we are returning it as-is to caller. If my understanding is correctEINTR
indicates that syscall was interrupted and there might not be any actual error. In which case should we retry? in a loop? I think we had this discussion before somewhere, what was decided from that?
Apart from this, lgtm 👍
b930ae1
to
1ee2515
Compare
Thanks @YJDoc2,
Sure, I ran clippy. BTW, why not introduing clippy in CI ?
Though we didn't discuss it in great depth, we talked about this topic. |
Clippy is in CI, but we have intentionally excluded experimental crates from cargo workspace because of which clippy does not run on those crates.
Yep, that's exactly what I was looking for. In this case, ok we are handling it correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I re-labeled this to experimental, as we have still kept the crate in experimental. Once we move this and start using it in youki, that PR should be marked as feature. |
Fixed several points based on the feedback I received.
#2718
This PR updates the logic of xattr.
If a file already has an xattr label, the
REPLACE
method is used.If a file doesn't have an xattr label, the
CREATE
method is used.This PR removes anyhow from selinux.