cgroups v1 memory integration test #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 tasks
Codecov Report
@@ Coverage Diff @@
## main #473 +/- ##
==========================================
- Coverage 60.46% 60.45% -0.02%
==========================================
Files 82 82
Lines 12150 12152 +2
==========================================
- Hits 7347 7346 -1
- Misses 4803 4806 +3 |
utam0k
reviewed
Nov 13, 2021
Comment on lines
+66
to
+68
| fn can_run() -> bool { | ||
| Path::new(CGROUP_MEMORY_LIMIT).exists() && Path::new(CGROUP_MEMORY_SWAPPINESS).exists() | ||
| } |
utam0k
approved these changes
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially exactly like runtime-tools. This should however address this unresolved issue with runtime-tools: opencontainers/runtime-tools#721
On systems with swap disabled in the kernel this test will likely be skipped entirely. Thing might not be the ideal behavior in that case, but I didn't want to change behavior from runtime-tools too much.