Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroups v1 memory integration test #473

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

tsturzl
Copy link
Collaborator

@tsturzl tsturzl commented Nov 13, 2021

Essentially exactly like runtime-tools. This should however address this unresolved issue with runtime-tools: opencontainers/runtime-tools#721

On systems with swap disabled in the kernel this test will likely be skipped entirely. Thing might not be the ideal behavior in that case, but I didn't want to change behavior from runtime-tools too much.

@codecov-commenter
Copy link

Codecov Report

Merging #473 (ccde8c1) into main (8cc892a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   60.46%   60.45%   -0.02%     
==========================================
  Files          82       82              
  Lines       12150    12152       +2     
==========================================
- Hits         7347     7346       -1     
- Misses       4803     4806       +3     

Comment on lines +66 to +68
fn can_run() -> bool {
Path::new(CGROUP_MEMORY_LIMIT).exists() && Path::new(CGROUP_MEMORY_SWAPPINESS).exists()
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@utam0k utam0k merged commit 73e4a86 into youki-dev:main Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants